From d9c5ad27e77c3ff427d7626d3cb7ae9b2b8ecea3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=99=88=E6=B2=85?= <907037276@qq.com> Date: Tue, 25 Aug 2026 11:35:48 +0800 Subject: [PATCH] fix: move task allocation index creation out of runtime --- .../service/impl/TrainingTaskServiceImpl.java | 9 --------- .../service/impl/TrainingTaskServiceImplTest.java | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/src/main/java/com/sztzjy/linkCommerce/service/impl/TrainingTaskServiceImpl.java b/src/main/java/com/sztzjy/linkCommerce/service/impl/TrainingTaskServiceImpl.java index 36075d2..99f88a2 100644 --- a/src/main/java/com/sztzjy/linkCommerce/service/impl/TrainingTaskServiceImpl.java +++ b/src/main/java/com/sztzjy/linkCommerce/service/impl/TrainingTaskServiceImpl.java @@ -208,7 +208,6 @@ public class TrainingTaskServiceImpl implements TrainingTaskService { } sort++; } - ensureTaskAllocationClassIndex(); defaultTasksInitialized = true; } } @@ -716,14 +715,6 @@ public class TrainingTaskServiceImpl implements TrainingTaskService { trainingTaskClassConfigTableChecked = true; } - private void ensureTaskAllocationClassIndex() { - if (jdbcTemplate == null) { - return; - } - jdbcTemplate.execute("CREATE INDEX IF NOT EXISTS idx_task_allocation_class_disabled_module " - + "ON task_allocation (class_id, disabled_status, module)"); - } - TrainingTask buildTask(TrainingTaskImportDTO row, int rowNumber, List errors) { String projectName = StringUtils.trimToEmpty(row.getProjectName()); String taskKey = StringUtils.trimToEmpty(row.getTaskKey()); diff --git a/src/test/java/com/sztzjy/linkCommerce/service/impl/TrainingTaskServiceImplTest.java b/src/test/java/com/sztzjy/linkCommerce/service/impl/TrainingTaskServiceImplTest.java index 3c09aad..7292bb4 100644 --- a/src/test/java/com/sztzjy/linkCommerce/service/impl/TrainingTaskServiceImplTest.java +++ b/src/test/java/com/sztzjy/linkCommerce/service/impl/TrainingTaskServiceImplTest.java @@ -27,6 +27,7 @@ import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; import static org.mockito.ArgumentMatchers.any; import static org.mockito.ArgumentMatchers.anyString; +import static org.mockito.ArgumentMatchers.contains; import static org.mockito.ArgumentMatchers.isNull; import static org.mockito.ArgumentMatchers.startsWith; import static org.mockito.Mockito.mock; @@ -38,6 +39,19 @@ import static org.mockito.Mockito.when; class TrainingTaskServiceImplTest { + @Test + void defaultTaskInitializationDoesNotRunTaskAllocationSchemaDdl() { + TrainingTaskServiceImpl service = new TrainingTaskServiceImpl(); + service.trainingTaskMapper = mock(TrainingTaskMapper.class); + service.jdbcTemplate = mock(JdbcTemplate.class); + when(service.trainingTaskMapper.selectByTaskKey(anyString())) + .thenReturn(storedTask("existing-task", "new-product-survey")); + + service.ensureDefaultTasks(null); + + verify(service.jdbcTemplate, never()).execute(contains("task_allocation")); + } + @Test void splitListSupportsCommonSeparators() { TrainingTaskServiceImpl service = new TrainingTaskServiceImpl();